tdm
-
Content Count
801 -
Joined
-
Last visited
-
Days Won
84
Posts posted by tdm
-
-
I'm implementing the UI for device specific features. So a couple of questions...
The keyboard map option should show a few common, sane, useful options. Like, say, making FN plus top row keys send F#. What other useful options do you think should be there?
Currently the keyboard backlight stays on while the screen is on and the slider is out. Would it be useful to have an option to time out the keyboard back light after a period of inactivity?
Any other interesting ideas?
-
1
-
1
-
-
17 minutes ago, Craig said:
So if the phone is squeezed with keyboard closed, it registers a keypress, and wakes up. I believe this has been mentioned before, just noticed it myself now. So it may be good idea to turn off/ignore keyboard when closed.
https://github.com/tdm/android_device_fxtec_pro1/issues/31
-
3
-
-
Alright things are moving right along now...
I've got the touch screen margin/deadzone implemented and a nice little settings preference for it. The display margin will not happen until later, if at all. That's much more difficult to implement and intrusive to the system (it will likely require a reboot to take effect).
I'll be adding a keyboard layout setting (qwerty/qwertz) next. Then I'll see what I can do with the fingerprint reader mitigations.
-
1
-
7
-
-
1 hour ago, Craig said:
Is there a preferred root solution? Or you just don't support root directly on device at all? I saw you mention in another thread that root would persist thru lineage ota updates, does that apply to magisk root and/or something else?
I'd only tried adb root recently, and works fine for file management etc. But can one use it to install apps that require root permissions?
There is an add-on su package for Lineage. See the extras download page.
-
4
-
-
25 minutes ago, zurvan2 said:
Do Lineage and/or Sailfish have OTA updates that work while rooted?
I've always been under the assumption that stock + rooted is the simplest to maintain, but perhaps I've drawn incorrect conclusions.
Lineage has a persist facility that is used by gapps, the su package, etc.
I haven't run Sailfish yet, but my understanding is that it's more like a traditional Linux distro than Android. So it surely has root facilities built-in.
-
1 hour ago, EskeRahn said:
Indeed it is confusing that the Pro1 is called a slider, as it does not slide...
But I guess no one have come up with a good descriptive word.
The movement reminds me of a dolphin jumping out of the waterr. So my least bad suggestion is "Flipper", that both relates "flipping" it open and the famous film, but people also associate flipping with opening a clamshell, so not good.... I would love it if someone had a good descriptive word for it.
Retractable micro laptop? 🙂
-
1
-
-
6 minutes ago, EskeRahn said:
There are a few scrollbars with the slider only 20 pixels wide (Small Display size, even less with Smaller and 15 with Smallest).
E.g. in the Settings, Apps, See all
You can scroll with a vertical swipe anywhere on the screen for that. The scroll bar is just a visual indicator of your position in the list. I couldn't imagine requiring the user to hit that tiny scroll bar with their finger.
-
2
-
-
2 minutes ago, david said:
I think that one came from the factory, not from an OTA, hence why it is missing. Is there a reason you can't unroot temporarily?
@tdm, does your EDL tool allow for extracting the images from a stock phone?
I could extract images from the current stock and make a EDL package and/or a fastboot package. But I've been rather busy and quite honestly it's not a priority. The only use I have for stock is extracting vendor blobs for the Lineage build... 😄
-
1
-
-
1 minute ago, david said:
I don't use LOS yet, but just contributing ideas.
With the dead zones, an option to change the physical resolution that is reported to apps would also be nice. That way, edge UI elements that a null solution would make inactive can be solved for.
Another to add to the list is double tap on screen to wake it. I can't remember if that is already available.
I'm not as familiar with how the physical resolution is presented to apps. But I'm not sure that will really be necessary. Playing around with a dead zone of 32 pixels feels pretty good and does not seem to impair anything.
The screen is supposed to be capable of dt2w. I'll have to dig into the BSP history to see what they did to disable it.
-
6 minutes ago, Kranchan said:
So what you're saying is I need to unroot my phone? What nonsense. Are there any third party apps that can force it to install?
If you want to run stock, you play by the rules of stock. The only way to install updates with a modified system partition is for someone else to provide the data to flash manually via fastboot. I haven't personally seen any factory packages provided since the 2019-12-03 release.
If you want to root your phone and be freed from this nonsense, don't run stock. Lineage is coming along nicely and Sailfish is supposed to be rather good as well.
-
Poking around a bit in the touchscreen driver. Adding code for the side dead zones is trivial and it works here. Hooking it up to a sysfs node and adding a setting item in the settings app will be a bit more work, but very doable.
Not sure about the fingerprint reader yet. I may implement two options: one to only activate the reader when the screen is not off and one to limit the amount of time between reads. I personally like the latter -- I love to be able to unlock the device without pressing any physical keys. But I'm not really sure exactly how to implement either of them. I'll have to do some playing around.
After that, it sounds like a decrypting TWRP is probably the third most popular request.
And don't get discouraged or frustrated if your request is lower on the priority list. These things should all happen in short order now that my war with a2dp has been won.
-
1
-
6
-
-
The AdUps updater is provided to the OEM as a binary package so I can't say for sure what reason 20 is. However, I can say that any modification to the system or vendor partition will cause an update to fail. This includes even mounting the partition read/write once. The only way to get back to a state where OTA updates will succeed is to replace your modified partition with a pristine, bit-for-bit copy. Reading behind your fail dialog it looks like you are on 2019-12-03 right now. The fastboot package for that is probably floating around somewhere. If not, let me know and I can provide it for you. When you get it, simply flash your system image and you should be good again:
fastboot flash system system.img
If you have modified both slots:
fastboot flash system_a system.img
fastboot flash system_b system.img
Similarly for vendor, if that's been modified.
-
Alright, so time to vote on issues to work on. Assuming that audio generally works (reports indicate it does in test7) and a2dp works (it will in test8), what is your biggest issue with running Lineage? Here's a list to start, mostly cribbed from the issues page:
* FM Radio does not work.
* WiFi signal strength broken.
* SELinux is permissive.
* Notification LED and/or vibration issues (anyone other than @Polaris see this?)
* ExFAT support for large sdcards (generally 64gb+).
* Allow dead touch zones on screen edges.
* Mitigate accidental fingerprint touches.
* Other (write-in) ...?
Or I can work on a decrypting TWRP if that's your biggest issue.
-
1
-
-
Holy crap, I finally got a2dp working. That took waaaaaaay too long, but it's working now. Next build will have it, probably tomorrow since I am a bit busy today and there's some other stuff I want to fix/add also.
-
10
-
-
1 minute ago, Craig said:
I flashed magisk (with lineage recovery) and now adb root gives me an error about production mode. Is this expected behavior? any workaround?
I don't use or support magisk, sorry.
-
29 minutes ago, Craig said:
Thanks. Now I see what you mean about error prone. I thought I double checked stuff and yep, that explained it. So now F1-F8 working. But still not sure why not F9-F12
30:0010:0043 F9
14:0011:0044 F10
38:0012:0057 F11
54:0013:0058 F12
Also, now I understand you intend a GUI for this in the future, that is even more awesome. For android or pc?
keymap 903 B · 0 downloads keymap.comments.txt 970 B · 0 downloads
Key 9 is index 13, KEY_9 is 10 (0x0a), KEY_F9 is 67 (0x43), so "13:0a:43".
I'll let you figure out the rest. 🙂
As for the GUI, I'm intending to have something relatively simple. Perhaps pick from a handful of canned layouts, and maybe a few tick boxes for modifications (like your F# keys).
PS1: if you mess up, you can always echo "qwerty" > layout and it will reset.
PS2: you can diff the original keymap file and your changed one to see what you have modified.
PS3: you do not have to have a full keymap in your file, only the changes that you want to make.
-
6 hours ago, cinaeco said:
Huh... that's strange to hear since it seems people can use aptX on stock. Or does that mean the license is only available on stock and not in LOS (and is there anyway to bring that over if that's the case)?
I would like to see proof of people using aptX on stock. Because I do not see the aptX libraries in the stock image. So unless Qualcomm has embedded the aptX libraries somewhere unexpected, or someone has added them manually, I don't see how it is possible for aptX to work on stock.
It is LineageOS policy to include only what stock includes. This is to avoid any potential issues with licensing. So i cannot add aptX on LineageOS (officially anyway).
-
1
-
-
8 hours ago, Craig said:
Can I include comments in the file? // or # or anything? Just to keep track of stuff easier....
No, I had intended this to be fronted by a GUI. But I can add the ability to ignore comments.
8 hours ago, Craig said:Here's my line for F6:
19:0007:00d0
any idea what's wrong?
KEY_F6 is 64, so that should be 19:0007:0040
8 hours ago, Craig said:And, some praise! I'm finally starting to understand why you're hiding the slant-arrow keys from user and handling them this way. Your method will allow us to use standard aosp layouts, yet control Fn independently in this easy to edit keymap file. I like it. Of course I still want to remap my right slant arrow and just use the left for this functionality, but you said that's coming, so I'm very pleased. I😉
Thanks. 🙂
-
1
-
-
10 minutes ago, JooJooBee666 said:
The pro1 doesn't have an aptX license so that property should not be set.
-
51 minutes ago, JooJooBee666 said:
@tdm The items I was just referring to were a line or 2 in the build.prop file. Also, looking at the file comparison, I noted a few additional audio libraries in the lib64 that are not present in the latest update to the vendor files (libaudioalso.so, libaoa.so and libaudio_log_utils.so). I'm guessing those are not necessary?
Anyhow, I'll compile an updated vendor.img tomorrow with the changes you pushed and see how it goes.
Okay well if you could share those lines from build.prop that might help.
I'll look into those audio libs... my device tree started life as a copy of the 1+5/5t device tree, which is also msm8998 so the libs list should be pretty close to accurate.
-
test7 is up. This has some missing audio libs that should make audio behave better. Please test and let me know. a2dp is still broken but other bluetooth functions seem to be okay (tested file transfer). @EskeRahn this will hopefully make [email protected] behave better.
@EskeRahn no I didn't do any screen calibration that I'm aware.
@Kabbone yes double tap to sleep works.
-
5
-
-
@Craig I'll respond once here...
In theory gapps should persist from install to install. If that is not working, someone may need to investigate. You do not need to re-install the recovery once you have it. I'll try to get the instructions updated.
The slant arrows are fully dead keys in the current Lineage build. I would like to make them customizable but haven't gotten there yet, as there are higher priority issues. After they are customizable, however, you will still need to keep at least one key as KEY_FN (or whatever I decide to make it) for a fully dead modifier. But you will be able to use the other however you wish. You are currently able to make KEY_FN+KEY_# into KEY_F# (but obviously there are only ten digits so I don't know what you have in mind for F11 and F12). You are also able to remap KEY_FN+KEY_DEL into KEY_INS. There is no GUI for this, you need to know the physical key numbers and the Linux key codes. Reference the keyboard driver here for the physical key numbers and the Linux header here for the key codes. You remap keys by writing to the file "/sys/bus/i2c/drivers/aw9523b/6-0058/keymap" in a format that I mentioned earlier: "key:code:fn-code", where "key" is the physical key number in decimal, "code" is the regular Linux key code in hex, and "fn-code" is the slant-arrow Linux key code logically OR-ed with any modifiers (0x8000 for shift, 0x4000 for ctrl, 0x2000 for alt). So let's make KEY_FN+KEY_1 send KEY_F1. The "1" key is physical key 57, KEY_1 is 2 (0x02), and KEY_F1 is 59 (0x3b). Note you will need to be root to do this (adb root, adb shell):
echo "57:02:3b" > "/sys/bus/i2c/drivers/aw9523b/6-0058/keymap"
To send a shifted F1, you would use "57:02:803b".
To map KEY_FN+KEY_DELETE to KEY_INSERT, use "21:6f:6e". I think I will probably make it the default for next build, thanks. 🙂
Locking the screen may be done with either KEY_SCREENLOCK (152 or 0x98) or KEY_POWER (116 or 0x74). You'll need to decide which physical key to use for that. Perhaps KEY_FN+KEY_SPACE?
This is all very tedious, error prone, and time consuming. So you can create a file "/persist/data/keyboard/keymap" that has the keymap that you like and it will be loaded at boot.
-
1
-
3
-
-
3 hours ago, JooJooBee666 said:
@tdm Thanks. I noticed some missing libs as well but none seemed connected to audio (I don't know what they do exactly) so I didn't bother with those. I also noticed some of the missing a2dp items as well but don't use BlueTooth so didn't bother. I can test today if you push to the repos soon but I gotta have everything working again in the next 5 hours as I have to be out and about this evening.
The libs I found are vendor/lib/libgcs*.so. I already had the 64-bit versions of those, but apparently the 32-bit versions are also needed. What a2dp items did you find? I'm still not getting a2dp to work. 😕
-
1 hour ago, Slion said:
So changing the keyboard type is really not possible from the application side.
It just loads OVERLAY types.
Possibly doable on rooted device I guess.@tdm On LineageOS is there any chance you guys could provide a way for the user to select how she wants to use the keyboard, ALPHA or FULL?
The keyboard character map file determines the type, FULL or ALPHA. It is loaded at boot and cannot be changed after. Perhaps I could implement an option in settings to switch. The documentation is here. I am currently placing the default kcm file in "
/vendor/usr/keychars/DEVICE_NAME.kcm". The setting could place a modified keymap in, say, "/data/system/devices/keychars/Vendor_XXXX_Product_XXXX.kcm".-
1
-
LineageOS, Current status : 16.0 Test Builds
in Support
Posted
Doesn't the auto rotation quick toggle do what you want?