LineageOS, Current status : 16.0 Test Builds

[JooJooBee666 84]

On 2/29/2020 at 8:04 PM, tdm said:

Try playing with the audio buffer sizes, and maybe diff 1+5 settings.

I tried a few things today, but no luck.  HOWEVER, I did find something interesting and it also explains why I thought it was fixed.  If there is crackling audio, simply plug in or unplug the usb, then it stops until the app shutdowns or phone goes to sleep again.  I'm not sure whether or not it because another sound is being played when that occurs or if something else is somehow being triggered.  I grabbed some adb logs of it occurring but haven't narrowed it down to anything yet. 

[RoThe 5]

I just flashed test8 build, coming from stock. 
Does anybody else still have problems with calls? I saw on Git, the issue seems to be fixed.
After a fresh reboot I called my Pro1 from my other phone and apparently the Pro1's mic didn't work. After I turned on speakers in the call it worked, even after turning speakers off again. That seems to be working now.

 I am not able to hear the other person though, sound is just muted. Works though, if I turn speakers on -> stops working if I turn them off again.

Maybe my "phone call" speaker is just broken? Is there a way to check that?
I also tried with a Telegram call, same result.
If I call with my bluetooth headset connected, everything works fine.

I did those tests with a completely fresh install after I realized it wasn't working with already a few apps installed and rooted. I don't have GApps installed.
I live in Germany using a Telekom (T-Mobile) SIM card, if that matters.
I never tested a call with stock Rom, so I am not sure if it was working there.

Apart from that I also have slight audio crackling, but I see you are already aware of that.

Do you want me to provide a log file? I'm not sure how to log it though..

Edited March 3, 2020 by RoThe

[D1ggs 141]

27 minutes ago, RoThe said:

I just flashed test8 build, coming from stock. 
Does anybody else still have problems with calls? I saw on Git, the issue seems to be fixed.
After a fresh reboot I called my Pro1 from my other phone and apparently the Pro1's mic didn't work. After I turned on speakers in the call it worked, even after turning speakers off again. That seems to be working now.

 I am not able to hear the other person though, sound is just muted. Works though, if I turn speakers on -> stops working if I turn them off again.

Maybe my "phone call" speaker is just broken? Is there a way to check that?
I also tried with a Telegram call, same result.
If I call with my bluetooth headset connected, everything works fine.

I did those tests with a completely fresh install after I realized it wasn't working with already a few apps installed and rooted. I don't have GApps installed.
I live in Germany using a Telekom (T-Mobile) SIM card, if that matters.
I never tested a call with stock Rom, so I am not sure if it was working there.

Apart from that I also have slight audio crackling, but I see you are already aware of that.

Do you want me to provide a log file? I'm not sure how to log it though..

Make sure your APN is set correctly. Mine wasn't and that was the cause of my woes. 

[Craig 1,435]

On 3/1/2020 at 8:08 PM, JooJooBee666 said:

If there is crackling audio, simply plug in or unplug the usb, then it stops until the app shutdowns or phone goes to sleep again. 

This actually works!  Just unplug charger (or plug it in) and the crackle stops.   Very weird.   I wonder if that works on stock too and nobody noticed til now.

Edited March 3, 2020 by Craig

[david 929]

9 minutes ago, Craig said:

This actually works!  Just unplug charger (or plug it in) and the crackle stops.   Very weird.   I wonder if that works on stock too and nobody noticed til now.

I have noticed that when in WhatsApp, if you play audio and then let the proximity sensor turn off the screen, which stops the audio, when you restart playing, it is often better sound quality.  Obviously different than USB, but similar in that doing something changes the quality.  I can try the USB trick with stock in a while and report back.

 

[Craig 1,435]

Another problem is speaker placement, when holding the phone landscape, I tend to muffle both speakers with my hands.  Can't fix that in software, but in Pro² might be good for speakers to be in the screen half.

[RoThe 5]

40 minutes ago, D1ggs said:

Make sure your APN is set correctly. Mine wasn't and that was the cause of my woes. 

Thanks, I tried. Still got the same symptoms though.
Isn't the APN setting for mobile internet though?

I also made sure to not let the screen turn off, didn't make a difference though.

I tried to generate a log with "adb logcat" there are a lot of entries, I hope that's ok.
I entered the command, called my Pro1 and turned speaker on and off once then ended the call and stopped logging.

log.txt

Edited March 3, 2020 by RoThe

[david 929]

3 hours ago, Craig said:

This actually works!  Just unplug charger (or plug it in) and the crackle stops.   Very weird.   I wonder if that works on stock too and nobody noticed til now.

I just tried it and I still get audio crackling on stock if I plug in and unplug the USB.

[auvo.salmi 135]

Just flashed Lineage to my Pro1. Heck, previous time for me was Cyanogenmod on Motorola Defy around 2011... But installation was easy and the adb/fastboot stuff was simple on my Debian pc. Haven't had time to play much wit the device, but seems like everything is working. Except banking apps and my job (Outlook) email, which are not permitted because of rooted device. Is there a way to solve this already?

[SteffenWi 139]

27 minutes ago, auvo.salmi said:

Except banking apps and my job (Outlook) email, which are not permitted because of rooted device

You should really not use any of those as long as we don't have an official build with a properly signed image and SELinux enabled.

[brunoais 334]

3 hours ago, auvo.salmi said:

Just flashed Lineage to my Pro1. Heck, previous time for me was Cyanogenmod on Motorola Defy around 2011... But installation was easy and the adb/fastboot stuff was simple on my Debian pc. Haven't had time to play much wit the device, but seems like everything is working. Except banking apps and my job (Outlook) email, which are not permitted because of rooted device. Is there a way to solve this already?

Just use Magisk for that.

[auvo.salmi 135]

Ok? From what I read, I got that Magisk isn't supported by LOS or the developer, and it might cause some other problems.

Another problem I found out is that I am missing some symbols on my keyboard. I have a physical keyboard with Finnish FinQwerty layout. It worked neatly on stock, but some of my symbols are missing. For example looks like nothing provides @ on the keyboard. Yellow arrow+2 gives " so it is working like shift or something, but most of the top row give what they should by yellow arrow+number. Also looks like I do not have ' on my keyboard. The button which should provide it just gives me Ö, which is mapped to that button without a modifier in  lowercase. So yellow arrow works as a shift there also.

[brunoais 334]

@auvo.salmiDid you try FinQWERTY or FxQWERTY? The ones behind those two projects are quite responsive and maybe you can ask for a keyboard layout that is compatible with your needs.

[auvo.salmi 135]

Fin. Yep perhaps I should ask from the app developer. But it worked properly in stock, so I thought that the problem could be in LOS.

[_DW_ 628]

@auvo.salmi Try SHIFT+' ?   Did you change your keyboard layout or is it on Default in settings?  As SHIFT+2 would normally be " on a UK keyboard?

 

[auvo.salmi 135]

Yes I changed to FinQwerty as I made on stock. Now changed back to default which do fix the problem, but also removes Scandinavian keys from the physical keyboard. In Finnish computer layout there's also " in shift+2, but @ is alt+2. On Finqwerty it should work as follows: yellow arrow+any button=the symbol which is marked to the button with yellow, AND shift+number=the same symbol as shift+number on pc. Now both of modifiers, shift+yellow arrow work as shift when FinQwerty is set. So, tl:dr shift works as intended in FinQwerty but yellow arrow doesn't; it works also as shift.

Edited March 4, 2020 by auvo.salmi
clarification

[EskeRahn 5,471]

18 minutes ago, auvo.salmi said:

Yes I changed to FinQwerty as I made on stock. Now changed back to default which do fix the problem, but also removes Scandinavian keys from the physical keyboard. In Finnish computer layout there's also " in shift+2, but @ is alt+2. On Finqwerty it should work as follows: yellow arrow+any button=the symbol which is marked to the button with yellow, AND shift+number=the same symbol as shift+number on pc. Now both of modifiers, shift+yellow arrow work as shift when FinQwerty is set. So, tl:dr shift works as intended in FinQwerty but yellow arrow doesn't; it works also as shift.

When I use Finqwerty for qwertY Danish, I see the same on "2" BUT it works fine on "P" (giving P resp /) and "L" but not en neighbouring "Å" and "Æ" with YelArr.

Also both Sh+YelArr+3 and Ctrl+YelArr+3 gives nothing rather than £ on lineage ...

So I guess we would need a special variant of the FinQwerty maps for the approach this lineage implementation uses...

Note that if you check with e.g. "Keyevent display", Pressing Fn does not return a code in it self on this Lineage.

[tdm 2,322]

@auvo.salmi the idea for the Lineage keyboard driver is to emulate a full PC keyboard.  @Gigadoc2 had a long and detailed reply on the github issue page, which is very informative and I encourage others to read here.  The idea is that you select your physical keyboard as QWERTY or QWERTZ and then let the standard Android keyboard layout stuff do its thing.

 

I do not have a QWERTZ device.  And even if I did, I am a sheltered mono-lingual American so I wouldn't know how it's supposed to behave.  The current QWERTZ layout was done with a picture of a QWERTZ pro1 device and a picture of a US-INTL keyboard side-by-side with absolutely no testing at all.  So it is not surprising that some things are not exactly correct (indeed, it is somewhat surprising that it is not more broken).

 

I would greatly appreciate if all you QWERTZ folks could get together and come up with a keymap that fits best.  I'll be happy to re-post the instructions for modifying the keymap.  Alternatively, if that is not possible, we can discuss making additional layouts (but I don't know what to call them...)

 

[Craig 1,435]

Keyboard is mapped differently than stock at driver level in Lineage, and handles the slant arrow keys directly, so they cannot be used in custom layouts, so most definitely cannot use finqwerty layouts designed for stock.

But you're a lot less likely to need them now.  Although not as quick as layout, you can get special letters by longpress of english letter.

Are you using QWERTZ?    If so, there's a system setting 'keyboard' that you can select qwertz from there.  I believe that only affects what happens when you press slant arrow + keys.   But per github, that keymap isn't 100% correct yet.

Have you tried the built-in German layout?  I dunno if it works right or not, but I do know on my qwerty device if I select german layout, it swaps y/z and changes a lot of the other non-letter keys (and changes shift+top row) etc, hopefully matches pro1's keys...

 

Edited March 4, 2020 by Craig

[FlyingAntero 871]

1 hour ago, Craig said:

Keyboard is mapped differently than stock at driver level in Lineage, and handles the slant arrow keys directly, so they cannot be used in custom layouts, so most definitely cannot use finqwerty layouts designed for stock.

But you're a lot less likely to need them now.  Although not as quick as layout, you can get special letters by longpress of english letter.

If that is the case, Lineage OS is no go for me as a Scandic. It is not usable to access Scandic letters by long pressing some key during writing. I would rather take little bit buggy driver instead. I hope that F(x)tec is going to have different solution.

Or then I need to buy Scandic version If it is available some day.

Edit: At first I didn't understand correctly. See my reply below.

Edited March 4, 2020 by FlyingAntero

[Craig 1,435]

23 minutes ago, FlyingAntero said:

If that is the case, Lineage OS is no go for me as a Scandic. It is not usable to access Scandic letters by long pressing some key during writing. I would rather take little bit buggy driver instead. I hope that F(x)tec is going to have different solution.

Or then I need to buy Scandic version If it is available some day.

It doesn't mean someone cannot write custom kcm's for use on our device under linage.  It just means they cannot use slant arrow keys in the kcm as before, those combinations are in a different keymap file.      You could make it behave exactly the same as any stock finqwerty layout if you really want.   

But did you try any built in scandic layouts?   Swedish, Danish, Finnish, Norwegian etc all there.  You may not even need further customization.

(And for that matter, with the next OTA, I expect stock will be doing some changes to keyboard, so finqwerty layouts for stock will need to be updated then anyway).

Edited March 4, 2020 by Craig

[tdm 2,322]

9 minutes ago, Craig said:

It doesn't mean someone cannot write custom kcm's for use on our device under linage.  It just means they cannot use slant arrow keys in the kcm as before, those combinations are in a different keymap file.      You could make it behave exactly the same as any stock finqwerty layout if you really want.   

But did you try any built in scandic layouts?   Danish, Finnish, Norwegian etc all there.  You may not even need customization.

(And for that matter, with the next OTA, I expect stock will be doing some changes to keyboard, so finqwerty layouts for stock will need to be updated then anyway).

 

... but keep in mind, the slant arrows will be configurable at some point.  It's on my to-do list.

 

[FlyingAntero 871]

13 minutes ago, Craig said:

It doesn't mean someone cannot write custom kcm's for use on our device under linage.  It just means they cannot use slant arrow keys in the kcm as before, those combinations are in a different keymap file.      You could make it behave exactly the same as any stock finqwerty layout if you really want.   

But did you try any built in scandic layouts?   Swedish, Danish, Finnish, Norwegian etc all there.  You may not even need further customization.

(And for that matter, with the next OTA, I expect stock will be doing some changes to keyboard, so finqwerty layouts for stock will need to be updated then anyway).

Thanks for the clarification. At first I didn't understand correctly. I thought that Pro1 couldn't be remapped at all after driver update (like BlackBerry phones after Oreo update). So, we just need to make new files after driver update for custom layouts.

I tried native Finnish remapping but it is done for QWERTY only so it is not usable for QWERTZ units.

[tdm 2,322]

So I'm talking to the Lineage folks and discovered that there is a setting to only accept fingerprint touches when the screen is not off.  But it is a build-time setting.  That is, you cannot toggle it.  So I'm not sure if it would be appropriate because one of the cool things I like about fingerprint sensors is the ability to unlock the device without touching any other keys.

 

Aside from that, I did discover a way to control the fingerprint behavior without doing anything too hacky.  It just involves copying the AOSP fingerprint service to the pro1 device tree and modifying it.  So my thoughts for changes are (1) do not accept touches less than two seconds apart, and (2) allow a configurable option for ignoring touches when screen is off.  Any other ideas?

 

 

[FlyingAntero 871]

 

19 minutes ago, tdm said:

So I'm talking to the Lineage folks and discovered that there is a setting to only accept fingerprint touches when the screen is not off.  But it is a build-time setting.  That is, you cannot toggle it.  So I'm not sure if it would be appropriate because one of the cool things I like about fingerprint sensors is the ability to unlock the device without touching any other keys.

 

Aside from that, I did discover a way to control the fingerprint behavior without doing anything too hacky.  It just involves copying the AOSP fingerprint service to the pro1 device tree and modifying it.  So my thoughts for changes are (1) do not accept touches less than two seconds apart, and (2) allow a configurable option for ignoring touches when screen is off.  Any other ideas?

 

 

I think that option 2 would be better. Then user could use application like WaveUp (pocket mode) to wake up the screen and then just place finger to the sensor. If user has to wait 2 seconds to unlock phone via fingerprint sensor it might be too slow. Pressing power button and then placing finger to the reader would be faster I think.

Edit: One idea would be to allow greater number of wrong fingerprint attemps and disable vibration on false read. Then false reads would not disturb the user but user would still be able to use the sensor when screen is off.

Edited March 4, 2020 by FlyingAntero